Skip to content

Add more info on useful workflows #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

Closes #703.
cc @mark-i-m I've never used git worktrees before, can you check everything seems correct, and add things that may be missing?

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks :)

Minor suggestions, but other than that r=me

@mark-i-m
Copy link
Member

mark-i-m commented Jun 2, 2020

CI failures appear related to expired certificates, but I seem to be able to reach these websites in my browser?

@mark-i-m
Copy link
Member

mark-i-m commented Jun 2, 2020

@LeSeulArtichaut could you rebase on master?

LeSeulArtichaut and others added 2 commits June 3, 2020 17:13
Co-authored-by: mark-i-m <mark-i-m@users.noreply.github.com>
Co-authored-by: spastorino <spastorino@gmail.com>
@LeSeulArtichaut
Copy link
Contributor Author

Rebased on master so CI passes now (thanks @mark-i-m!). I'll merge this to clean up the PR list.

@LeSeulArtichaut
Copy link
Contributor Author

Oh I need an approval first 🙄

@chrissimpkins
Copy link
Member

Oh I need an approval first 🙄

done!

@LeSeulArtichaut LeSeulArtichaut merged commit 2c2fb3f into rust-lang:master Jun 3, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the workflows branch June 3, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more info on useful workflows
4 participants